Skip TestRepoCommitsStatusParallel on CI #24741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
added
type/testing
skip-changelog
|
I am sure it's fixable and should be fixed, I don't think it is right to skip failed tests. Otherwise why the tests are written? |
|
I think maybe silverwind means we have know the bug and just skip it but keep the issue open. After we fix it, then reenable the test. |
|
Yes, keep the issue open, but skip it as not skipping is just a waste of contributor time and CI resources. |
lunny
approved these changes
May 16, 2023
GiteaBot
added
the
lgtm/need 1
|
I have objection for skipping it. You have the PR #24567 and I think bug should and could be fixed. |
wxiaoguang
added
status/blocked
|
Just took a look at the details again, it looks like due to the ability limitation of XORM and how Gitea uses databases and the supported database version requirements. I guess there is no easy way to make all database happy for some transaction problems. So I won't block the "Skip" . The similar thing also applies to the container's in-process mutex workaround. |
wxiaoguang
approved these changes
May 16, 2023
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
yardenshoham
approved these changes
May 16, 2023
|
I will continue working on #24567 |
pull-request-size
bot
added
the
size/XS
Merge this until then? |
GiteaBot
removed
the
reviewed/wait-merge
|
Decided to merge, real fix can come in #24567. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 18, 2023
* giteaofficial/main: Enable two vue eslint rules (go-gitea#24780) Add two eslint plugins (go-gitea#24776) Mark `models/fixtures` as generated (go-gitea#24775) Fix TestMinioStorageIterator skip message (go-gitea#24765) Fix missed table name on iterate lfs meta objects (go-gitea#24768) Revert "Fix missed table name on iterate lfs meta objects" (go-gitea#24764) Make the color of zero-contribution-squares in the activity heatmap more subtle (go-gitea#24758) Fix missed table name on iterate lfs meta objects Skip TestMinioStorageIterator on CI (go-gitea#24762) Support no label/assignee filter and batch clearing labels/assignees (go-gitea#24707) Support for status check pattern (go-gitea#24633) Updates to doc (go-gitea#24757) Ignore build for docs only (go-gitea#24761) Fix team members API endpoint pagination (go-gitea#24754) Make mailer SMTP check have timed context (go-gitea#24751) Add @garymoon to MAINTAINERS (go-gitea#24752) Skip TestRepoCommitsStatusParallel on CI (go-gitea#24741) Respect original content when creating secrets (go-gitea#24745)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #22109