Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove meta charset from HTML5 documents #24744

Merged
merged 4 commits into from
May 16, 2023
Merged

Remove meta charset from HTML5 documents #24744

merged 4 commits into from
May 16, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 16, 2023 •
edited
Loading

When <!DOCTYPE html> is present, the default (and only valid) charset it utf-8 so it does not need to be specified.

Also we do serve with HTML with Content-Type: text/html; charset=utf-8, so it is duplicate info anyways.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2023
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 16, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 16, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) May 16, 2023 04:14
@techknowlogick techknowlogick merged commit 30d9222 into go-gitea:main May 16, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 16, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 16, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 16, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d10f090 
* giteaofficial/main:
  Remove meta charset from HTML5 documents (go-gitea#24744)
@silverwind silverwind deleted the rmcharset branch May 16, 2023 07:02
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @techknowlogick @wxiaoguang @lunny @GiteaBot