Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enhancements of profile readmes #24753

Closed
wants to merge 6 commits into from

Conversation

a1012112796
Copy link
Member

follow #23260, do some enhancement to make it better.

  • reuse readme file finding and render logic in repo file render function, then all features in repo's readme file like locolize file name, file reference (like using figure in profile repo) and issue/pull reference will be usefull alse. that's same with github.
    example:
    image

  • make profile repo name configable for all user (TIP: you can disable it by entry a not exist repository name :) )

  • less serverError in profile readme render logic

follow go-gitea#23260, do some enhancement to make it better.

- reuse readme file finding and render logic in repo
  file render function, then all features in repo's
  readme file like locolize file name, file reference
  and issue/pull reference will be usefull alse.
  that's same with github.

- make profile repo name configable for all user (TIP:
  you can disable it by entry a not exist repository
  name :) )

- less `serverError` in profile readme render logic

Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 16, 2023
@a1012112796 a1012112796 added the type/enhancement An improvement of existing functionality label May 16, 2023
Copy link
Member

@yardenshoham yardenshoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also not show private repos but that can be another PR

options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
routers/web/repo/render/render.go Outdated Show resolved Hide resolved
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
models/user/setting_keys.go Outdated Show resolved Hide resolved
silverwind pushed a commit that referenced this pull request Aug 4, 2023
As mentioned in the original thread (#23260) and in the enhancements PR
#24753, this PR ensures the .profile repository is public before the
README file is shown.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
@a1012112796 a1012112796 closed this Sep 8, 2023
@a1012112796 a1012112796 deleted the zzc/dev/profile branch September 8, 2023 01:52
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants