Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mailer SMTP check have timed context (#24751) #24759

Merged
merged 1 commit into from May 17, 2023
Merged

Make mailer SMTP check have timed context (#24751) #24759

merged 1 commit into from May 17, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #24751 by @wxiaoguang

Make mailer SMTP check have timed context

Otherwise Gitea may block for long time if the DNS request blocks.

@wxiaoguang @GiteaBot
Make mailer SMTP check have timed context (go-gitea#24751)
e9f54bf 
Make mailer SMTP check have timed context

Otherwise Gitea may block for long time if the DNS request blocks.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot added the type/enhancement An improvement of existing functionality label May 16, 2023
@GiteaBot GiteaBot added this to the 1.19.4 milestone May 16, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2023
@silverwind silverwind enabled auto-merge (squash) May 16, 2023 21:01
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 17, 2023
@silverwind silverwind merged commit 57f520e into go-gitea:release/v1.19 May 17, 2023
2 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 17, 2023
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 3, 2023
@GiteaBot @earl-warren
Make mailer SMTP check have timed context (go-gitea#24751) (go-gitea#…
9cf864c 
…24759)

Backport go-gitea#24751 by @wxiaoguang

Make mailer SMTP check have timed context

Otherwise Gitea may block for long time if the DNS request blocks.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 57f520e)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 15, 2023
@techknowlogick techknowlogick deleted the backport-24751-v1.19 branch September 9, 2023 05:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@a1012112796 a1012112796 Awaiting requested review from a1012112796

@delvh delvh Awaiting requested review from delvh

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.19.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GiteaBot @lunny @silverwind @wxiaoguang