Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace drone exec to act_runner exec in test README.md #24791

Merged
merged 5 commits into from May 18, 2023
Merged

replace drone exec to act_runner exec in test README.md #24791

merged 5 commits into from May 18, 2023

Conversation

a1012112796
Copy link
Member

as title, follow #24494, old drone exec is not used now, suggest replace.

example result:

屏幕截图 2023-05-18 171915

@a1012112796
replace drone exec to act_runner exec in test READEME.md
4db7f7e 
as title, follow go-gitea#24494, old `drone exec` has broken,
suggest replace.

Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 18, 2023
@a1012112796 a1012112796 added the type/docs This PR mainly updates/creates documentation label May 18, 2023
silverwind
silverwind reviewed May 18, 2023
View reviewed changes
.github/workflows/pull-db-tests.yml Outdated
@@ -41,7 +41,7 @@ jobs:
with:
go-version: ">=1.20.0"
- name: Add hosts to /etc/hosts
run: echo "127.0.0.1 pgsql ldap minio" | sudo tee -a /etc/hosts
run: '[ -f "/.dockerenv" ] || echo "127.0.0.1 pgsql ldap minio" | sudo tee -a /etc/hosts'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is specific to the docker daemon, it will not work in other OCI container runtimes like podman. A slightly better check would be

[ -e "/.dockerenv" ] || [ -e "/run/.containerenv" ]

@silverwind silverwind changed the title replace drone exec to act_runner exec in test READEME.md replace drone exec to act_runner exec in test README.md May 18, 2023
a1012112796 and others added 2 commits May 18, 2023 20:43
@a1012112796 @silverwind
Apply suggestions from code review
89ec2a0 
Co-authored-by: silverwind <me@silverwind.io>
@a1012112796
apply suggestions
28cdb2f 
Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2023
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 18, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) May 18, 2023 19:19
@techknowlogick techknowlogick merged commit 25d4f95 into go-gitea:main May 18, 2023
15 checks passed
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 18, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 18, 2023
@a1012112796 a1012112796 deleted the zzc/dev/docs_test_help branch May 19, 2023 00:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 19, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
585d015 
* giteaofficial/main:
  replace `drone exec` to `act_runner exec` in test README.md (go-gitea#24791)
  Fix OAuth loading state (go-gitea#24788)
  Remove duplicated issues options and some more refactors (go-gitea#24787)
  Revert "Mark `models/fixtures` as generated (go-gitea#24775)" (go-gitea#24782)
  Remove background on user dashboard filter bar (go-gitea#24779)
silverwind added a commit to bl00mber/gitea that referenced this pull request May 21, 2023
@silverwind
Merge branch 'main' into milestone-labels
e336a1e 
* main: (90 commits)
  Refactor rename user and rename organization (go-gitea#24052)
  Use `CommentList` instead of `[]*Comment` (go-gitea#24828)
  Fix topics deleted via API not being deleted in org page (go-gitea#24825)
  Return `404` in the API if the requested webhooks were not found (go-gitea#24823)
  Decouple the different contexts from each other (go-gitea#24786)
  [skip ci] Updated translations via Crowdin
  Add RTL rendering support to Markdown (go-gitea#24816)
  [skip ci] Updated translations via Crowdin
  Update JS dependencies (go-gitea#24815)
  Fix duplicate tooltip hiding (go-gitea#24814)
  Mute repo names in dashboard repo list (go-gitea#24811)
  Rework label colors (go-gitea#24790)
  Fix max width and margin of comment box on conversation page (go-gitea#24809)
  Allow all URL schemes in Markdown links by default (go-gitea#24805)
  Some refactors for issues stats (go-gitea#24793)
  Implement actions artifacts (go-gitea#22738)
  Fix Actions being enabled accidentally (go-gitea#24802)
  Change `add_on` in `keys_ssh.tmpl` (go-gitea#24803)
  replace `drone exec` to `act_runner exec` in test README.md (go-gitea#24791)
  Fix OAuth loading state (go-gitea#24788)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@a1012112796 @silverwind @techknowlogick @delvh @GiteaBot