Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test TestLoggerPause #24882

Closed
silverwind opened this issue May 23, 2023 · 1 comment · Fixed by #24883
Closed

Flaky Test TestLoggerPause #24882

silverwind opened this issue May 23, 2023 · 1 comment · Fixed by #24883
Labels
type/testing
Milestone
1.20.0

Comments

@silverwind
Copy link
Member

silverwind commented May 23, 2023 •
edited

https://github.com/go-gitea/gitea/actions/runs/5055503857/jobs/9071789890?pr=24864

--- FAIL: TestLoggerPause (0.20s)
    logger_test.go:100: 
        	Error Trace:	/home/runner/work/gitea/gitea/modules/log/logger_test.go:100
        	Error:      	Not equal: 
        	            	expected: []string{}
        	            	actual  : []string{"info-level\n"}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,3 @@
        	            	-([]string) {
        	            	+([]string) (len=1) {
        	            	+ (string) (len=11) "info-level\n"
        	            	 }
        	Test:       	TestLoggerPause

Maybe regression from #24726.
@silverwind silverwind mentioned this issue May 23, 2023
Merged
3 tasks
@wxiaoguang
Copy link
Contributor

It needs a little "sleep", otherwise some writer hasn't been "paused"

Fix flakey test in logger test #24883

@wxiaoguang wxiaoguang mentioned this issue May 23, 2023
Merged
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 23, 2023
@wxiaoguang wxiaoguang added this to the 1.20.0 milestone May 23, 2023
@wxiaoguang wxiaoguang removed the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/testing
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Fix flakey test in logger test wxiaoguang/gitea
2 participants
@silverwind @wxiaoguang