Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <empty> in administration/config-cheat-sheet.en-us.md #24905

Merged
merged 2 commits into from May 24, 2023
Merged

Fix <empty> in administration/config-cheat-sheet.en-us.md #24905

merged 2 commits into from May 24, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented May 24, 2023

Before

Screen Shot 2023-05-24 at 15 54 02 Screen Shot 2023-05-24 at 15 50 05 Screen Shot 2023-05-24 at 15 50 16

After

Screen Shot 2023-05-24 at 15 52 53 Screen Shot 2023-05-24 at 15 53 03 Screen Shot 2023-05-24 at 15 53 13

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 24, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2023
@HesterG HesterG added the type/docs This PR mainly updates/creates documentation label May 24, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 24, 2023
silverwind
silverwind approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did noticed these in #23581 too, but could not finish that PR because it had too many false positives.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 24, 2023
@lunny lunny merged commit 9ad5cad into go-gitea:main May 24, 2023
17 checks passed
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 24, 2023
@HesterG HesterG deleted the fix-empty branch May 24, 2023 08:32
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 25, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
0f56349 
* upstream/main: (21 commits)
  `zh-cn` translation for usage docs (go-gitea#24897)
  Add chinese documentations for installation (go-gitea#24904)
  Improve RunMode / dev mode (go-gitea#24886)
  Add chinese documentations for `Packages` (go-gitea#24914)
  Rework notifications list (go-gitea#24812)
  New webhook trigger for receiving Pull Request review requests (go-gitea#24481)
  Use file filters action instead of Github's files filter (go-gitea#24877)
  Update Asciidoc markup example with safe defaults (go-gitea#24920)
  Add self to maintainers (go-gitea#23644)
  Create pull request for base after editing file, if not enabled on fork (go-gitea#24841)
  Reduce verbosity of dev commands (go-gitea#24917)
  Merge different languages for language stats (go-gitea#24900)
  Add missing test case and fix typo in tests (go-gitea#24915)
  Improve confusable character string (go-gitea#24911)
  Improve Actions CSS (go-gitea#24864)
  Fix <empty> in administration/config-cheat-sheet.en-us.md (go-gitea#24905)
  Only validate changed columns when update user (go-gitea#24867)
  Rename docs packages title from xxx Packages Repository -> xxx Package Registry (go-gitea#24895)
  Fix can’t move anymore items in repo project boards (go-gitea#24892)
  Make environment-to-ini  support loading key value from file (go-gitea#24832)
  ...

# Conflicts:
#	web_src/css/helpers.css
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HesterG @lunny @silverwind @GiteaBot