Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some documents: release version, logging, NFS lock (#25202) #25204

Merged
merged 2 commits into from Jun 12, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #25202 by @wxiaoguang

Close #23654

Close #24684

@techknowlogick I still think we need to rename https://dl.gitea.com/gitea/1.20/ to https://dl.gitea.com/gitea/1.20-nightly/

/gitea/1.20/ is quite confusing, it needs these words to explain why. If we call it 1.20-nightly, the FAQ can be simplified a lot.

…25202)

Close go-gitea#23654
Close go-gitea#24684

@techknowlogick I still think we need to rename
https://dl.gitea.com/gitea/1.20/ to
https://dl.gitea.com/gitea/1.20-nightly/

`/gitea/1.20/` is quite confusing, it needs these words to explain why.
If we call it `1.20-nightly`, the FAQ can be simplified a lot.
@GiteaBot GiteaBot added the type/docs This PR mainly updates/creates documentation label Jun 12, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 12, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2023
@GiteaBot GiteaBot requested review from lunny and wolfogre June 12, 2023 09:06
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2023
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 12, 2023
@lunny lunny merged commit 0ad5ae0 into go-gitea:release/v1.20 Jun 12, 2023
21 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 12, 2023
@alexrjs
Copy link

alexrjs commented Sep 5, 2023

Additional info: I updated gitea on my k3s cluster to 1.20.3-rootless, and in addition I updated with k3sup to k3s to v1.27.4+k3s1. After rebooting gitea db (sqlite3) was looked. gitea db is located on an NFS share mapped to the default container location for rootless. After reading the comments of "LevelDB/LevelQueue could get stuck on NFS when NFS locking doesn't work properly", I tried a

root@k3s01:/etc/init.d# ./rpcbind restart

on the k3s host, which ran the gitea container. After that the gitea db lock on the nfs share was gone and it worked again. So that might help as an additionional "try that" in the documentation.

Cheers and thanks for your great work... ;-)

@techknowlogick techknowlogick deleted the backport-25202-v1.20 branch September 5, 2023 18:41
@go-gitea go-gitea locked and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants