Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fetch form action for lock/unlock/pin/unpin on sidebar #25380

Merged
merged 17 commits into from Jun 29, 2023
Merged

Use fetch form action for lock/unlock/pin/unpin on sidebar #25380

merged 17 commits into from Jun 29, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Jun 20, 2023

Before:

Screen Shot 2023-06-20 at 11 59 11

Might trigger many posts when keep clicking the buttons above.

Screen Shot 2023-06-20 at 11 52 28 Screen Shot 2023-06-20 at 11 52 37

After (PR sidebar, Same for issue):

Untitled.mov

For delete, it is using base/modal_actions_confirm subtemplate, and we might need another general solution for this (maybe add another attribute to the subtemplate or something)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2023
@HesterG HesterG added the topic/ui Change the appearance of the Gitea UI label Jun 20, 2023
@silverwind
Copy link
Member

Loading state on those buttons needs a few tweaks I see, will check later.

@lunny lunny added this to the 1.21.0 milestone Jun 20, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2023
@silverwind
Copy link
Member

silverwind commented Jun 22, 2023 •
edited

Improved the loading state via a new class single-button-form in 6476dac:

Screenshot 2023-06-22 at 22 03 43

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 22, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 23, 2023
@silverwind silverwind self-requested a review June 27, 2023 01:03
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Jun 27, 2023
@silverwind
Copy link
Member

Need to check above points.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 29, 2023
@silverwind silverwind enabled auto-merge (squash) June 29, 2023 03:37
@silverwind silverwind merged commit c6f1fb1 into go-gitea:main Jun 29, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 29, 2023
@HesterG HesterG deleted the lock-pin-fetch branch July 4, 2023 10:13
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@HesterG @silverwind @wxiaoguang @delvh @lunny @GiteaBot