Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrate page layout on mobile #25507

Merged
merged 2 commits into from Jun 26, 2023
Merged

Fix migrate page layout on mobile #25507

merged 2 commits into from Jun 26, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jun 25, 2023

Fixes: #25462

On supporting browsers, text in description is wrapped equally.

Screenshot 2023-06-26 at 00 17 21 Screenshot 2023-06-26 at 00 14 51

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2023
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2023
@@ -3,9 +3,9 @@
<div class="ui middle very relaxed page grid">
<div class="column">
{{template "repo/migrate/helper" .}}
<div class="ui three stackable cards">
<div class="ui cards migrate-entries">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that most styles are provided by migrate-entries and migrate-entry now? Is "ui cards" still necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.ui.card at least is necessary for styling aspecs like border and background and more. .ui.cards might be removable.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 26, 2023
@lunny lunny enabled auto-merge (squash) June 26, 2023 09:29
@lunny lunny merged commit da6df0d into go-gitea:main Jun 26, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jun 26, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 26, 2023
@silverwind silverwind deleted the mig branch June 26, 2023 11:25
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The icon on the migrate page is too large
5 participants