Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Following up fixes for "Fix inconsistent user profile layout across tabs" #25739

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Following up fixes for "Fix inconsistent user profile layout across tabs" #25739

merged 3 commits into from
Jul 7, 2023

Conversation

wxiaoguang
Copy link
Contributor

Follow #25625 (comment)

  1. Fix the incorrect "project view" layout
  2. Fix the "follow/unfollow" link on "packages" and "projects" tab

Before:

image

After:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 7, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Jul 7, 2023
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 7, 2023
puni9869
puni9869 reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@puni9869 puni9869 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, Overall looks good
💯

templates/shared/user/profile_big_avatar.tmpl Outdated Show resolved Hide resolved
templates/shared/user/profile_big_avatar.tmpl Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2023
@wxiaoguang
Copy link
Contributor Author

@puni9869

The fix for "follow/unfollow" is this: 9e6e716

@puni9869
Copy link
Member

puni9869 commented Jul 7, 2023

@puni9869

The fix for "follow/unfollow" is this: 9e6e716

Nice one,

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 7, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 7, 2023
@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 7, 2023
@silverwind silverwind merged commit 128d77a into go-gitea:main Jul 7, 2023
24 checks passed
@wxiaoguang wxiaoguang deleted the fix-follow branch July 7, 2023 15:27
@wxiaoguang wxiaoguang mentioned this pull request Jul 9, 2023
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@puni9869 puni9869 puni9869 left review comments

@denyskon denyskon denyskon approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wxiaoguang @puni9869 @silverwind @denyskon @delvh @GiteaBot