Proposal: Remove/replace "web" as the default action for the binary

[jolheiser]

Feature Description

Currently gitea is just a shortcut for gitea web when invoking the binary. In many cases where a human¹ is running the CLI, I would wager that this is not what they expect or want to do.

I'm creating this proposal to gather feedback from the community, but I think this would potentially make the initial experience less confusing.

We could, if this proposal goes through, more accurately contain the code that generates directories/files to the commands that actually need/expect those things to exist. Of course we should also improve those commands to make them less destructive (or creative) in their own right, but I think this would implicitly help avoid issues such as #25938

As a side-note, my suggestion for a replacement would be gitea help as the shortcut. At least then the default action is to show you the available actions.

Impact

Thankfully the example systemd service already explicitly invokes the web sub-command, so anyone who has copied the command from there should be fine.

The docker run scripts also appear to set this correctly.

The docs also explicitly invoke web.

Nixpkgs is correct.
Alpine is correct.
Arch is correct.
Gentoo is correct.
OpenSUSE is correct.

This means that only those who do not use/copy the above defaults would be affected, and then only those that do not explicitly invoke the web sub-command.

Screenshots

No response

Footnotes

1. other than our wonderful, very human, and definitely not robot developers who likely run this command a ton when making changes ↩

[wxiaoguang]

but I think this would implicitly help avoid issues such as #25938

More contexts: actually it's not related.

The reason behind "#25938" is that the "./gitea --help" is documented to be used to show the "work-path / custom-path / custom-conf". ref:

gitea/custom/conf/app.example.ini

Line 15 in cc73e84

;; reported as part of the default configuration when running `gitea --help` or on start-up. The order they are emitted there is slightly different but we will list them here in the order they are set-up.

To resolve various bugs, Refactor path & config system #25330 starts using the WORK_PATH in app.ini as a stable work-path value. So "./gitea --help" needs to read the "app.ini" to show the correct work-path.

However, Gitea's config system is a mess, the ini file might be rewritten during config loading, and some directories might be created during the loading too.

---

ps: I am neutral for keeping or removing the "web" as shortcut.

[jolheiser]

fwiw I also entirely agree with the above, other commands need some work to help stabilize when/how Gitea writes to files.

The core of the proposal is simply that the web sub-command is probably an unexpected entry-point for someone running the base gitea binary.

In the earlier days it made more sense, as Gitea was largely built to be invoked programmatically. Now, however, the CLI includes various sub-commands where someone is more likely to experiment or use other utilities.

[wxiaoguang]

As the first step, I think we can remove the "web" related options from the default command

This is done in Refactor to use urfave/cli/v2 #25959

Before, many "web"-only options pollute the global options:

$ ./gitea --help
...
GLOBAL OPTIONS:
   --help, -h                     show help
   --custom-path value, -C value  Set custom path (defaults to '{WorkPath}/custom')
   --config value, -c value       Set custom config file (defaults to '{WorkPath}/custom/conf/app.ini')
   --work-path value, -w value    Set Gitea's working path (defaults to the Gitea's binary directory)
   --port value, -p value         Temporary port number to prevent conflict (default: "3000")
   --install-port value           Temporary port number to run the install page on to prevent conflict (default: "3000")
   --pid value, -P value          Custom pid file path (default: "/run/gitea.pid")
   --quiet, -q                    Only display Fatal logging errors until logging is set-up
   --verbose                      Set initial logging to TRACE level until logging is properly set-up
   --version, -v                  print the version

After:

$ ./gitea --help
...
GLOBAL OPTIONS:
   --help, -h                     show help
   --version, -v                  print the version
   --custom-path value, -C value  Set custom path (defaults to '{WorkPath}/custom')
   --config value, -c value       Set custom config file (defaults to '{WorkPath}/custom/conf/app.ini')
   --work-path value, -w value    Set Gitea's working path (defaults to the Gitea's binary directory)