Use AfterLoad instead of AfterSet on Structs #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantkoenig
approved these changes
Sep 30, 2017
models/login_source.go
Outdated
| case "updated_unix": | ||
| source.Updated = time.Unix(source.UpdatedUnix, 0).Local() | ||
| } | ||
| // AfterLoad is invoked from XORM after setting the value of a field of this object. |
There was a problem hiding this comment.
Comment seems stale, please update it (also in other places)
|
And @ethantkoenig, could you help me update the latest xorm since my |
tboerger
added
the
lgtm/need 2
|
@lunny I don't have write permissions, so I don't think I can merge into your branch |
|
I could create a separate PR that just updates xorm if that'd be helpful |
|
@lunny fixed govendor hash |
Codecov Report
@@ Coverage Diff @@
## master #2628 +/- ##
==========================================
- Coverage 27.29% 27.11% -0.19%
==========================================
Files 86 86
Lines 17144 17064 -80
==========================================
- Hits 4680 4627 -53
+ Misses 11786 11759 -27
Partials 678 678
Continue to review full report at Codecov.
|
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest
xormprovides new processorAfterLoad. For performance,AfterSetwill be invoked when a field be filled, butAfterLoadonly is invoked after all fields be filled. And alsoAfterLoadallows a parametersession *xorm.Sessionthat you can load data from the same session with the object to reduce memory usage.