Do not highlight #number in documents
#26365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
delvh
changed the title
#number in documents
delvh
approved these changes
Aug 7, 2023
GiteaBot
added
lgtm/need 1
- Currently the post processing will transform all issue indexes (such as `go-gitea#6`) into an clickable link. - This makes sense in an situation like issues or PRs, where referencing to other issues is quite common and only referencing to their issue indexing is an handy and efficient way to do it. - Currently this is also run for documents (which is the user profile and viewing rendered files), but in those situations it's less common to reference issues by their index and instead could mean something else. - This patch disables this post processing for issue index for documents. Which matches Github's behavior. - Added unit tests. - Resolves https://codeberg.org/Codeberg/Community/issues/1120
earl-warren
force-pushed
the
wip-gitea-post-process
branch
from
174279f
to
27c5c54
Compare
denyskon
approved these changes
Aug 7, 2023
GiteaBot
added
lgtm/done
delvh
added
outdated/theme/markdown
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 8, 2023
* upstream/main: Start using template context function (go-gitea#26254) Allow package cleanup from admin page (go-gitea#25307) Fix text truncate (go-gitea#26354) Fix incorrect sort link with `.profile` repository (go-gitea#26374) Use more `IssueList` instead of `[]*Issue` (go-gitea#26369) Rename code_langauge.go to code_language.go (go-gitea#26377) Add changelog for 1.20.3 (go-gitea#26373) Do not highlight `#number` in documents (go-gitea#26365) Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect IssueIndex (go-gitea#26279) Fix nil pointer dereference error when open link with invalid pull index (go-gitea#26353)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6) into an clickable link.