Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user-content-* consistent with github #26388

Merged
merged 7 commits into from Aug 9, 2023

Conversation

CaiCandong
Copy link
Member

@CaiCandong CaiCandong commented Aug 8, 2023

Fix #26367
Related #19745

Thanks @lazyky for providing test cases

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 8, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 8, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Aug 8, 2023
@wxiaoguang
Copy link
Contributor

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 8, 2023
@silverwind
Copy link
Member

Merge or wait for #26388 (comment)?

@CaiCandong
Copy link
Member Author

CaiCandong commented Aug 9, 2023

Merge or wait for #26388 (comment)?

These three test cases have been added to the unit tests:#64f5bb1ad9bbb690b7cb890a643611f413132d0d,I apologize for not responding to comments in a timely manner.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 9, 2023
@silverwind silverwind enabled auto-merge (squash) August 9, 2023 08:40
@silverwind
Copy link
Member

Merge or wait for #26388 (comment)?

These three test cases have been added to the unit tests:#64f5bb1ad9bbb690b7cb890a643611f413132d0d,I apologize for not responding to comments in a timely manner.

Ah, I only saw the "fix lint" commit, didn't think it also added test cases :)

@silverwind silverwind merged commit d41aee1 into go-gitea:main Aug 9, 2023
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 9, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 10, 2023
* upstream/main:
  Pre-register OAuth2 applications for git credential helpers (go-gitea#26291)
  Make `user-content-* ` consistent with github (go-gitea#26388)
  Add pull request review request webhook event (go-gitea#26401)
  Introduce ctx.PathParamRaw to avoid incorrect unescaping (go-gitea#26392)
@CaiCandong CaiCandong deleted the bugfix/issue_26367 branch August 11, 2023 02:08
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 7, 2023
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anchors don't work when contains punctuation marks just like or (
6 participants