allow "latest" to be used in release vTag when downloading file #26748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
|
The idea is pretty good. The question in my mind is: could be the logic changed to: if |
lunny
reviewed
Aug 27, 2023
Yep I'll implement this, do you think we should allow new releases to be created with the "latest" name ? |
…ttps://github.com/merlleu/gitea into allow-latest-as-feature-vtag-in-attachment-download
wxiaoguang
reviewed
Aug 29, 2023
…ttps://github.com/merlleu/gitea into allow-latest-as-feature-vtag-in-attachment-download
|
Will be great to see this get implemented! |
wxiaoguang
approved these changes
Sep 6, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Sep 6, 2023
lunny
approved these changes
Sep 6, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 7, 2023
* giteaofficial/main: Fix schedule actions still running even if workflow disalbed (go-gitea#26939) Fix the missing repo count (go-gitea#26942) Improve SSH Key / GPG Key / Deploy Key UI (go-gitea#26949) [skip ci] Updated translations via Crowdin Update nginx recommendations (go-gitea#26924) docs: Update Profile README information (go-gitea#26947) Fix scoped label layout (go-gitea#26932) Move createrepository from module to service layer (go-gitea#26927) Add a documentation note for Windows Service (go-gitea#26938) allow "latest" to be used in release vTag when downloading file (go-gitea#26748) Extract common code to new template (go-gitea#26933) Show always repo count in header (go-gitea#26842) Show always repo count in header (go-gitea#26842) Artifacts retention and auto clean up (go-gitea#26131) Fix UI anomalies (go-gitea#26929) Fix the display of org level badges (go-gitea#26504)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In the discord I saw someone complaining that you can't use the "latest" keyword as release tag to download a specific file:
In his example:
https://www.uberwald.me/gitea/public/fvtt-ecryme/releases/latest/system.json
However the latest keyword works for the release page, so I think it's a good thing to implement this on the release attachment download url too.