Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mail notification logic to service layer #26905

Merged
merged 2 commits into from Sep 5, 2023
Merged

Move mail notification logic to service layer #26905

merged 2 commits into from Sep 5, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 5, 2023 •
edited

Extract from #22266

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 5, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 5, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2023
@lunny lunny merged commit a66d883 into go-gitea:main Sep 5, 2023
24 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 5, 2023
@lunny lunny deleted the lunny/move_mail_notify_service branch September 5, 2023 09:27
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 5, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
cefe080 
* giteaofficial/main:
  Move mail notification logic to service layer (go-gitea#26905)
  Improve DeleteByID (go-gitea#26904)
  Update backup instructions to align with archive structure (go-gitea#26902)
  More fixes for the "commit-body" (go-gitea#26898)
  Show queue's active worker number (go-gitea#26896)
  Remove CSS `has` selector and improve various styles (go-gitea#26891)
@techknowlogick techknowlogick modified the milestones: 1.22.0, 1.21.0 Sep 5, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@CaiCandong CaiCandong CaiCandong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @wxiaoguang @CaiCandong @techknowlogick @GiteaBot