Fix the secret regexp pattern on web page #26910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
lunny
approved these changes
Sep 5, 2023
GiteaBot
added
lgtm/need 1
|
Should we add a config option for this pattern? I think it is used in many places in the backend as well so one shared definition will help for these patterns to no longer go out of sync. The regexp must be compatible with both the JS and Golang flavor, but that's easily verified on https://regex101.com/. |
delvh
approved these changes
Sep 5, 2023
GiteaBot
added
lgtm/done
techknowlogick
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.20. @lng2020, please send one manually. 🍵 |
GiteaBot
added
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 6, 2023
* giteaofficial/main: Add missing translation (go-gitea#26926) Vendor `jquery.are-you-sure` with strict mode fixes (go-gitea#26901) Fix the secret regexp pattern on web page (go-gitea#26910) Add @chenrui333 as maintainer (go-gitea#26917) Move notification interface to services layer (go-gitea#26915) fetch emails of currently displayed user on admin page (go-gitea#26918) Improve LDAP group config documentation, fixes go-gitea#21159 (go-gitea#21227) update footer link to new landing page (go-gitea#26916) Remove `Named` interface (go-gitea#26913) Refactor secrets modification logic (go-gitea#26873) Add missing `reqToken()` to notifications endpoints (go-gitea#26914) feat(API): add routes and functions for managing user's secrets (go-gitea#26909) Move feed notification service layer (go-gitea#26908) Extract common code to new template (go-gitea#26903) Move ui notification to service layer (go-gitea#26907) Remove duplicated notify mail configuration on tests (go-gitea#26912) Move indexer notification to service layer (go-gitea#26906) # Conflicts: # templates/base/footer_content.tmpl
|
The code doesn't exist in v1.20, so we don't need a backport |
silverwind
removed
backport/manual
lunny
pushed a commit
that referenced
this pull request
Sep 21, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 21, 2023
silverwind
pushed a commit
that referenced
this pull request
Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
However, the error is caused by the web page not handling the post form failure, which is 400 bad requests in this case. But I'm not sure where to add the error handle. Any advice is appreciated.