Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hint when uploading a too large avatar #26935

Merged
merged 5 commits into from Sep 7, 2023
Merged

Improve hint when uploading a too large avatar #26935

merged 5 commits into from Sep 7, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 6, 2023

Fix #26390

@lunny lunny added the topic/ui-interaction Change the process how users use Gitea instead of the visual appearance label Sep 6, 2023
@lunny lunny added this to the 1.21.0 milestone Sep 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2023
@delvh delvh changed the title Improve hint for avatar upload size exceed Improve error hint when uploading a too large avatar Sep 6, 2023
@delvh delvh changed the title Improve error hint when uploading a too large avatar Improve hint when uploading a too large avatar Sep 6, 2023
delvh
delvh approved these changes Sep 6, 2023
View reviewed changes
options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 6, 2023
@delvh delvh self-requested a review September 6, 2023 11:26
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2023
@lunny @delvh
Apply suggestions from code review
e4d2c58 
Co-authored-by: delvh <dev.lh@web.de>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 7, 2023
@lunny @wxiaoguang
Update options/locale/locale_en-US.ini
2cd0bc8 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 7, 2023
@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 7, 2023
@lunny @silverwind
Update options/locale/locale_en-US.ini
3853312 
Co-authored-by: silverwind <me@silverwind.io>
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 7, 2023
@silverwind silverwind enabled auto-merge (squash) September 7, 2023 13:24
@silverwind silverwind merged commit f20e317 into go-gitea:main Sep 7, 2023
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 7, 2023
@lunny lunny deleted the lunny/improve_hint_size branch September 7, 2023 13:40
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 8, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
820ff43 
* giteaofficial/main:
  Add `yamllint` (go-gitea#26965)
  Fix yaml quoting (go-gitea#26964)
  [skip ci] Updated translations via Crowdin
  Add `actions/labeler` (go-gitea#26962)
  Team invite url fix when registration disabled (go-gitea#26950)
  Refactor dashboard/feed.tmpl (go-gitea#26956)
  Improve hint when uploading a too large avatar (go-gitea#26935)
  Replace `util.SliceXxx`  with `slices.Xxx`  (go-gitea#26958)
  Add reverseproxy auth for API back with default disabled (go-gitea#26703)
  Add "dir=auto" for input/textarea elements by default (go-gitea#26735)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@CaiCandong CaiCandong CaiCandong approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Inform the user about maximum profile picture size.
6 participants
@lunny @silverwind @wxiaoguang @CaiCandong @delvh @GiteaBot