Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RemoteAddress to mirrors #26952

Merged
merged 3 commits into from Sep 16, 2023
Merged

Add RemoteAddress to mirrors #26952

merged 3 commits into from Sep 16, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Sep 6, 2023

This PR adds a new field RemoteAddress to both mirror types which contains the sanitized remote address for easier (database) access to that information. Will be used in the audit PR if merged.

@KN4CK3R KN4CK3R added the type/enhancement An improvement of existing functionality label Sep 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 6, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 6, 2023
@puni9869
Copy link
Member

Any screenshots, if applicable?

@delvh delvh added the performance/speed performance issues with slow downs label Sep 16, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 16, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 16, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Sep 16, 2023
@KN4CK3R KN4CK3R enabled auto-merge (squash) September 16, 2023 15:54
@KN4CK3R KN4CK3R merged commit c766140 into go-gitea:main Sep 16, 2023
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 16, 2023
@KN4CK3R KN4CK3R deleted the enhancement-mirror branch September 16, 2023 16:29
delvh
delvh reviewed Sep 16, 2023
View reviewed changes
models/migrations/v1_21/v276.go
}

if err := sess.Iterate(new(Mirror), func(_ int, bean any) error {
m := bean.(*Mirror)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
m := bean.(*Mirror)
m := bean.(*Mirror)
if m.RemoteAddress != "" {
return nil
}

models/migrations/v1_21/v276.go
}

if err := sess.Iterate(new(PushMirror), func(_ int, bean any) error {
m := bean.(*PushMirror)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
m := bean.(*PushMirror)
m := bean.(*PushMirror)
if m.RemoteAddress != "" {
return nil
}

@delvh delvh modified the milestones: 1.22.0, 1.21.0 Sep 16, 2023
@lunny lunny mentioned this pull request Sep 17, 2023
Merged
lunny added a commit that referenced this pull request Sep 17, 2023
@lunny
Fix wrong migration for email address (#27106)
dcf4b9e 
On Iterate, `sess` should not be used in the closure function body.

Caused by #26952
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 17, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
1434f7a 
* giteaoffical/main: (23 commits)
  Search branches (go-gitea#27055)
  Fix wrong migration for email address (go-gitea#27106)
  [skip ci] Updated translations via Crowdin
  Support `.git-blame-ignore-revs` file (go-gitea#26395)
  Add `RemoteAddress` to mirrors (go-gitea#26952)
  Upgrading the actions/checkout@4 (go-gitea#27096)
  Next round of `db.DefaultContext` refactor (go-gitea#27089)
  Ui correction in mobile view nav bar left aligned items. (go-gitea#27046)
  Add missing deps to files-changed (go-gitea#27100)
  Use db.WithTx for AddTeamMember to avoid ctx abuse (go-gitea#27095)
  Drop Node.js 16 and update js dependencies (go-gitea#27094)
  Fix NPE when editing OAuth2 applications (go-gitea#27078)
  Use `print` instead of `printf` (go-gitea#27093)
  Add tests for db indexer in indexer_test.go (go-gitea#27087)
  [skip ci] Updated translations via Crowdin
  Allow empty Conan files (go-gitea#27092)
  Actions are no longer experimental, so enable them by default (go-gitea#27054)
  Update brew installation documentation since gitea moved to brew core package (go-gitea#27070)
  More refactoring of `db.DefaultContext` (go-gitea#27083)
  [skip ci] Updated translations via Crowdin
  ...
silverwind added a commit to silverwind/gitea that referenced this pull request Sep 17, 2023
@silverwind
Merge remote-tracking branch 'origin/main' into usefetch
8a6e43c 
* origin/main: (53 commits)
  Search branches (go-gitea#27055)
  Fix wrong migration for email address (go-gitea#27106)
  [skip ci] Updated translations via Crowdin
  Support `.git-blame-ignore-revs` file (go-gitea#26395)
  Add `RemoteAddress` to mirrors (go-gitea#26952)
  Upgrading the actions/checkout@4 (go-gitea#27096)
  Next round of `db.DefaultContext` refactor (go-gitea#27089)
  Ui correction in mobile view nav bar left aligned items. (go-gitea#27046)
  Add missing deps to files-changed (go-gitea#27100)
  Use db.WithTx for AddTeamMember to avoid ctx abuse (go-gitea#27095)
  Drop Node.js 16 and update js dependencies (go-gitea#27094)
  Fix NPE when editing OAuth2 applications (go-gitea#27078)
  Use `print` instead of `printf` (go-gitea#27093)
  Add tests for db indexer in indexer_test.go (go-gitea#27087)
  [skip ci] Updated translations via Crowdin
  Allow empty Conan files (go-gitea#27092)
  Actions are no longer experimental, so enable them by default (go-gitea#27054)
  Update brew installation documentation since gitea moved to brew core package (go-gitea#27070)
  More refactoring of `db.DefaultContext` (go-gitea#27083)
  [skip ci] Updated translations via Crowdin
  ...
@lunny lunny mentioned this pull request Sep 18, 2023
Merged
lafriks pushed a commit that referenced this pull request Sep 18, 2023
@lunny @wolfogre
Fix wrong xorm get usage on migration (#27111)
e644cc9 
Fix the bug on try.gitea.io

```log
2023/09/18 01:48:41 ...ations/migrations.go:635:Migrate() [I] Migration[276]: Add RemoteAddress to mirrors
2023/09/18 01:48:41 routers/common/db.go:34:InitDBEngine() [E] ORM engine initialization attempt #7/10 failed. Error: migrate: migration[276]: Add RemoteAddress to mirrors failed: exit status 128 - fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
 - fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
```

Caused by #26952

---------

Co-authored-by: Jason Song <i@wolfogre.com>
@yp05327 yp05327 mentioned this pull request Dec 5, 2023
Open
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh left review comments

@silverwind silverwind silverwind approved these changes

@puni9869 puni9869 puni9869 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them performance/speed performance issues with slow downs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KN4CK3R @puni9869 @silverwind @delvh @GiteaBot