Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chroma color tweaks #26978

Merged
merged 1 commit into from Sep 8, 2023
Merged

Chroma color tweaks #26978

merged 1 commit into from Sep 8, 2023

Conversation

silverwind
Copy link
Member

Before and after each:

  1. don't highlight yaml multiline string like comments in dark theme:
Screenshot 2023-09-08 at 17 12 53 Screenshot 2023-09-08 at 17 13 32
  1. highlight LiteralStringInterpol in light theme
Screenshot 2023-09-08 at 17 19 08 Screenshot 2023-09-08 at 17 19 23
  1. Use non-string color in NameAttribute in dark theme:
Screenshot 2023-09-08 at 17 24 41 Screenshot 2023-09-08 at 17 24 26
  1. Bring various colors in LiteralString and NameVariable into sync between the themes. I was not able to reproduce all tokens, but I guess it should not look too bad.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 8, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2023
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Sep 8, 2023
@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI and removed topic/ui Change the appearance of the Gitea UI labels Sep 8, 2023
@silverwind
Copy link
Member Author

silverwind commented Sep 8, 2023

In case anyone is wondering about err class:

image Screenshot 2023-09-08 at 17 52 12

GitHub renders such errors with red background, but I think it would look to bad if all JSX is rendered like that. Chroma is really bad at JS/JSX rendering in general.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 8, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 8, 2023
@jolheiser jolheiser merged commit 4693bdb into go-gitea:main Sep 8, 2023
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 8, 2023
@techknowlogick techknowlogick modified the milestones: 1.22.0, 1.21.0 Sep 8, 2023
@silverwind silverwind deleted the yamlcolor branch September 8, 2023 18:22
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 9, 2023
* giteaoffical/main:
  [skip ci] Updated translations via Crowdin
  Move some functions to service layer (go-gitea#26969)
  Lock yamllint and update indirect python deps (go-gitea#26979)
  Chroma color tweaks (go-gitea#26978)
  Add a new column schedule_id for action_run to track (go-gitea#26975)
  Improve flex list UI (go-gitea#26970)
  Clarify the git command Stdin hanging problem (go-gitea#26967)
  Add v1.20.4 changelog (go-gitea#26974)
  Check newly added node type before "attachDirAuto" (go-gitea#26972)
  Expanding documentation in queue.go (go-gitea#26889)
  move repository deletion to service layer (go-gitea#26948)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants