Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor system setting #27000

Merged
merged 11 commits into from Oct 5, 2023
Merged

Refactor system setting #27000

merged 11 commits into from Oct 5, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Sep 10, 2023 •
edited

This PR reduces the complexity of the system setting system.

It only needs one line to introduce a new option, and the option can be used anywhere out-of-box.

It is still high-performant (and more performant) because the config values are cached in the config system.

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2023
@wxiaoguang wxiaoguang mentioned this pull request Sep 10, 2023
Merged
@wxiaoguang wxiaoguang marked this pull request as draft September 10, 2023 12:59
@wxiaoguang wxiaoguang changed the title Refactor system setting WIP: Refactor system setting Sep 10, 2023
lunny
lunny reviewed Sep 11, 2023
View reviewed changes
models/system/setting.go Outdated Show resolved Hide resolved
@wxiaoguang wxiaoguang force-pushed the refactor-setting branch 3 times, most recently from bd80e39 to 6c6c309 Compare September 17, 2023 09:42
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2023
@wxiaoguang wxiaoguang force-pushed the refactor-setting branch 4 times, most recently from 850c0e4 to 8014055 Compare September 19, 2023 15:22
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Sep 19, 2023
@wxiaoguang wxiaoguang marked this pull request as ready for review September 19, 2023 15:53
@wxiaoguang
Copy link
Contributor Author

Almost ready for review.

@wxiaoguang wxiaoguang changed the title WIP: Refactor system setting Refactor system setting Sep 19, 2023
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 20, 2023
@lunny lunny added this to the 1.22.0 milestone Sep 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 4, 2023
@lunny lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 4, 2023
@wxiaoguang wxiaoguang merged commit 9f8d598 into go-gitea:main Oct 5, 2023
25 checks passed
@wxiaoguang wxiaoguang deleted the refactor-setting branch October 5, 2023 01:08
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 5, 2023
@wxiaoguang @GiteaBot
Refactor system setting (go-gitea#27000)
7087915 
This PR reduces the complexity of the system setting system.

It only needs one line to introduce a new option, and the option can be
used anywhere out-of-box.

It is still high-performant (and more performant) because the config
values are cached in the config system.
@GiteaBot GiteaBot mentioned this pull request Oct 5, 2023
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 5, 2023
@wxiaoguang wxiaoguang removed the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 5, 2023
lunny pushed a commit that referenced this pull request Oct 5, 2023
@GiteaBot @wxiaoguang
Refactor system setting (#27000) (#27452)
aaf35ee 
Backport #27000 by @wxiaoguang

This PR reduces the complexity of the system setting system.

It only needs one line to introduce a new option, and the option can be
used anywhere out-of-box.

It is still high-performant (and more performant) because the config
values are cached in the config system.


![image](https://github.com/go-gitea/gitea/assets/2114189/f8cdd743-1145-41ab-9f8f-3996aa97d440)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang mentioned this pull request Dec 30, 2023
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoguang @lunny @wolfogre @GiteaBot