Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract auth middleware from service #27028

Merged
merged 2 commits into from Sep 12, 2023
Merged

Extract auth middleware from service #27028

merged 2 commits into from Sep 12, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Sep 11, 2023 •
edited

Related #27027

Extract the router logic from services/auth/middleware.go into routers/web <-> routers/common <-> routers/api.

@KN4CK3R KN4CK3R added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 11, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 11, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Sep 11, 2023
@KN4CK3R KN4CK3R mentioned this pull request Sep 11, 2023
Open
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 12, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 12, 2023
@KN4CK3R KN4CK3R merged commit 591f586 into go-gitea:main Sep 12, 2023
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 12, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 12, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 12, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
85b3127 
* upstream/main:
  Add more package registry paths to the labeler (go-gitea#27032)
  Extract auth middleware from service (go-gitea#27028)
  S3: log human readable error on connection failure (go-gitea#26856)
  [skip ci] Updated translations via Crowdin
  Fix "delete" modal dialog for issue/PR (go-gitea#27015)
  Fix context cache bug & enable context cache for dashabord commits' authors (go-gitea#26991)
  fix: typo (go-gitea#27009)
  Use secure cookie for HTTPS sites (go-gitea#26999)
  Add fetch wrappers, ignore network errors in actions view (go-gitea#26985)
@delvh delvh modified the milestones: 1.22.0, 1.21.0 Sep 13, 2023
@KN4CK3R KN4CK3R deleted the refactor-auth-context-2 branch September 13, 2023 20:16
@yp05327 yp05327 mentioned this pull request Nov 22, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KN4CK3R @lunny @wxiaoguang @GiteaBot @delvh