Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Test Delivery and Replay webhook buttons when webhook is inactive (#27211) #27253

Merged
merged 2 commits into from Sep 25, 2023
Merged

Disable Test Delivery and Replay webhook buttons when webhook is inactive (#27211) #27253

merged 2 commits into from Sep 25, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #27211 by @yardenshoham

These buttons are now disabled when the webhook is not active.

The buttons were always enabled before this change.

Before

image

image

After

image

image

@GiteaBot GiteaBot added the type/enhancement An improvement of existing functionality label Sep 25, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Sep 25, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 25, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 25, 2023
@lunny lunny enabled auto-merge (squash) September 25, 2023 10:11
@lunny lunny merged commit 2774a2a into go-gitea:release/v1.21 Sep 25, 2023
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 25, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@delvh delvh delvh approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees

@yardenshoham yardenshoham

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GiteaBot @yardenshoham @delvh @lunny