Hide archived labels by default from the suggestions when assigning labels for an issue #27451

puni9869 · 2023-10-05T00:50:48Z

Followup of #27115
Finally closes #25237

Screenshots

Issue Sidebar

PR sidebar

PR sidebar with archived labels shown

… page

…onality

delvh

Your approach is one way of doing it.
There is one other possible approach:

I don't see a benefit in assigning archived labels.
They should only be removable from an issue.
It is basically the same approach as in the previous PR:

Always show selected labels or unarchived labels (including the archived hint if a label is archived).
However, don't show the checkbox to show archived labels, it is simply not present.
We may or may not still accept the URL parameter (show-archived=true) and handle it accordingly for power users who want

As we've discussed in person, I'm fine with either approach.

templates/repo/issue/labels/labels_selector_field.tmpl

…and pr detail page label drop down

…onality

web_src/js/features/repo-issue-list.js

…onality

puni9869 · 2023-10-06T18:45:11Z

Ready for review again.

web_src/js/features/repo-issue-list.js

…onality

Signed-off-by: puni9869 <punitinani1@hotmail.com>

…onality

web_src/js/features/repo-issue-list.js

…onality

puni9869 · 2023-10-08T05:20:26Z

can I get one more approval or review

…onality

web_src/js/features/repo-issue.js

silverwind · 2023-10-13T16:26:07Z

web_src/js/features/repo-issue.js

@@ -680,3 +680,10 @@ export function initIssueTemplateCommentEditors($commentForm) {
    initCombo($(el));
  }
 }
+
+export function initArchivedLabelHandler() {
+  if (!document.querySelector('.archived-label-hint')) return;


Why are we selecting for this hint? Seems brittle. Can the below loop stand on its own without this? If not, at least add a comment explaining the reason for this selector.

I will refactor this naming a little bit.

silverwind · 2023-10-13T16:29:14Z

Why is there no [Archived] label besides archived labels? Why not remove this checkbox and just sort archived labels last, always showing them, but with the tag?

I find the current UI confusing, and would rather rewrite the dropdown to a style similar to GitHub.

…onality

delvh · 2023-10-13T19:46:08Z

Yes, that will be the next step.
As far as I know, @puni9869 is already working on that.
But for now, we need at least something (for 1.21), and can still improve it later on.

silverwind

Not totally happy with it but I guess if you really must land it, go ahead.

…onality

…abels for an issue (go-gitea#27451) Followup of go-gitea#27115 Finally closes go-gitea#25237 ## Screenshots ### Issue Sidebar <img width="513" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/9f7fda2f-5a03-4684-8619-fd3498a95b41"> ### PR sidebar <img width="367" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/53db9b64-faec-4a67-91d6-76945596a469"> ### PR sidebar with archived labels shown <img width="352" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/9dc5050f-4e69-4f76-bb83-582480a2281e"> --------- Signed-off-by: puni9869 <punitinani1@hotmail.com> Co-authored-by: silverwind <me@silverwind.io>

@puni9869

…abels for an issue (#27451) (#27661) Backport #27451 by @puni9869 Followup of #27115 Finally closes #25237 ## Screenshots ### Issue Sidebar <img width="513" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/9f7fda2f-5a03-4684-8619-fd3498a95b41"> ### PR sidebar <img width="367" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/53db9b64-faec-4a67-91d6-76945596a469"> ### PR sidebar with archived labels shown <img width="352" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/9dc5050f-4e69-4f76-bb83-582480a2281e"> Signed-off-by: puni9869 <punitinani1@hotmail.com> Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com> Co-authored-by: silverwind <me@silverwind.io>

* giteaofficial/main: Improve the list header in milestone page (go-gitea#27302) Fix poster is not loaded in get default merge message (go-gitea#27657) Hide archived labels by default from the suggestions when assigning labels for an issue (go-gitea#27451) actions/setup-go use go-version-file (go-gitea#27651) Update agit-support.en-us.md (go-gitea#27652)

Adding archive label functionality for label selector in issue detail…

e25b7fc

… page

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2023

pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2023

github-actions bot added the topic/ui Change the appearance of the Gitea UI label Oct 5, 2023

puni9869 and others added 2 commits October 5, 2023 06:21

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

2fa6357

…onality

Reverting the linted code

8db7e06

puni9869 mentioned this pull request Oct 5, 2023

Improve the list header in milestone page #27302

Merged

puni9869 added 2 commits October 5, 2023 06:47

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

f0be3f7

…onality

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

0560ad0

…onality

delvh added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 5, 2023

delvh changed the title ~~Adding archive label functionality for label selector in issue/pr detail page~~ Hide archived labels from the suggestions when assigning labels for an issue by default Oct 5, 2023

delvh reviewed Oct 5, 2023

View reviewed changes

templates/repo/issue/labels/labels_selector_field.tmpl Outdated Show resolved Hide resolved

templates/repo/issue/labels/labels_selector_field.tmpl Outdated Show resolved Hide resolved

puni9869 and others added 3 commits October 5, 2023 23:50

Hiding the labels when there is no archived label is tagged in issue …

90116d8

…and pr detail page label drop down

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

33b01af

…onality

using archived label template

1a55eae

puni9869 commented Oct 5, 2023

View reviewed changes

web_src/js/features/repo-issue-list.js Outdated Show resolved Hide resolved

puni9869 added 2 commits October 6, 2023 19:20

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

62cbe2b

…onality

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

1f592c3

…onality

delvh reviewed Oct 6, 2023

View reviewed changes

web_src/js/features/repo-issue-list.js Outdated Show resolved Hide resolved

puni9869 and others added 3 commits October 7, 2023 08:19

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

009f923

…onality

Style correction

107accb

Signed-off-by: puni9869 <punitinani1@hotmail.com>

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

5e855a5

…onality

delvh approved these changes Oct 7, 2023

View reviewed changes

web_src/js/features/repo-issue-list.js Outdated Show resolved Hide resolved

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 7, 2023

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

d281bbe

…onality

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

e9062ba

…onality

github-actions bot added the modifies/frontend label Oct 8, 2023

puni9869 added 2 commits October 10, 2023 11:43

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

7101b32

…onality

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

c4db3ad

…onality

silverwind reviewed Oct 13, 2023

View reviewed changes

web_src/js/features/repo-issue.js Outdated Show resolved Hide resolved

Update web_src/js/features/repo-issue.js

e3bffa7

silverwind reviewed Oct 13, 2023

View reviewed changes

web_src/js/features/repo-issue.js Outdated Show resolved Hide resolved

Update web_src/js/features/repo-issue.js

b17d36a

silverwind reviewed Oct 13, 2023

View reviewed changes

web_src/js/features/repo-issue.js Outdated Show resolved Hide resolved

Update web_src/js/features/repo-issue.js

013008e

silverwind reviewed Oct 13, 2023

View reviewed changes

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

c3f1a40

…onality

Adding comments

f7813de

silverwind approved these changes Oct 16, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 16, 2023

delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 17, 2023

GiteaBot added 3 commits October 17, 2023 15:18

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

f52da8f

…onality

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

7b84f89

…onality

Merge branch 'main' into punit/update-pr-label-filter-archived-functi…

12411af

…onality

delvh changed the title ~~Hide archived labels from the suggestions when assigning labels for an issue by default~~ Hide archived labels by default from the suggestions when assigning labels for an issue Oct 17, 2023

delvh merged commit 4adc2a8 into go-gitea:main Oct 17, 2023
25 checks passed

GiteaBot added this to the 1.22.0 milestone Oct 17, 2023

GiteaBot mentioned this pull request Oct 17, 2023

Hide archived labels by default from the suggestions when assigning labels for an issue (#27451) #27661

Merged

GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 17, 2023

go-gitea locked as resolved and limited conversation to collaborators Jan 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide archived labels by default from the suggestions when assigning labels for an issue #27451

Hide archived labels by default from the suggestions when assigning labels for an issue #27451

puni9869 commented Oct 5, 2023 •

edited by delvh

delvh left a comment

puni9869 commented Oct 6, 2023

puni9869 commented Oct 8, 2023

silverwind Oct 13, 2023 •

edited

puni9869 Oct 13, 2023

silverwind commented Oct 13, 2023 •

edited

delvh commented Oct 13, 2023

silverwind left a comment

Hide archived labels by default from the suggestions when assigning labels for an issue #27451

Hide archived labels by default from the suggestions when assigning labels for an issue #27451

Conversation

puni9869 commented Oct 5, 2023 • edited by delvh

Screenshots

Issue Sidebar

PR sidebar

PR sidebar with archived labels shown

delvh left a comment

Choose a reason for hiding this comment

puni9869 commented Oct 6, 2023

puni9869 commented Oct 8, 2023

silverwind Oct 13, 2023 • edited

Choose a reason for hiding this comment

puni9869 Oct 13, 2023

Choose a reason for hiding this comment

silverwind commented Oct 13, 2023 • edited

delvh commented Oct 13, 2023

silverwind left a comment

Choose a reason for hiding this comment

puni9869 commented Oct 5, 2023 •

edited by delvh

silverwind Oct 13, 2023 •

edited

silverwind commented Oct 13, 2023 •

edited