Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable markdownlint no-duplicate-header (#27500) #27506

Merged
merged 1 commit into from Oct 7, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Oct 7, 2023

Backport #27500 by @silverwind

Duplicate headers in a single Markdown document are problemlematic because the auto-generated links won't be stable. Enable this rule with no exceptions which is also the default of markdownlint. For example:

# A
## Example
# B
## Example

Docasaurus will generated example and example-1 links for this. If the first heading is altered, the link example will unexpectedly move to the second example heading.

Ref: #27461 (comment)

Duplicate headers in a single Markdown document are problemlematic
because the auto-generated links won't be stable. Enable this rule with
no exceptions which is also the default of `markdownlint`. For example:

```md
# A
## Example
# B
## Example
```
Docasaurus will generated `example` and `example-1` links for this. If
the first heading is altered, the link `example` will unexpectedly move
to the second example heading.

Ref: go-gitea#27461 (comment)
@GiteaBot GiteaBot added type/docs This PR mainly updates/creates documentation topic/code-linting lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 7, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Oct 7, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 7, 2023
@GiteaBot GiteaBot requested review from delvh and lunny October 7, 2023 13:30
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 7, 2023
@silverwind silverwind enabled auto-merge (squash) October 7, 2023 13:30
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 7, 2023
@silverwind silverwind merged commit 65020fd into go-gitea:release/v1.21 Oct 7, 2023
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/code-linting type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants