Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade go-co-op/gocron to v1.31.1 #27511

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Oct 7, 2023

There seem to be intermittend test failures related to this module, downgrade it to have reliable CI again. Note: I have no idea whether the failures are actually because of that package, but it seems likely.

Example: #27489 (comment)

Edit: Looking at open issue of that package, it seems to have multiple concurreny issue. Maybe we should replace it entirely in the future.

There seem to be intermittend test failures related to this module,
downgrade it to have reliable CI again.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 7, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2023
@silverwind silverwind added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.21 This PR should be backported to Gitea 1.21 labels Oct 7, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 7, 2023
@techknowlogick techknowlogick merged commit e51f968 into go-gitea:main Oct 7, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 7, 2023
@GiteaBot
Copy link
Contributor

GiteaBot commented Oct 7, 2023

I was unable to create a backport for 1.21. @silverwind, please send one manually. 🍵

go run ./contrib/backport 27511
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Oct 7, 2023
@silverwind silverwind deleted the revert-gocron branch October 7, 2023 23:27
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 8, 2023
* giteaoffical/main: (79 commits)
  Pre-register OAuth application for tea (go-gitea#27509)
  Fix mermaid flowchart margin issue (go-gitea#27503)
  add a shortcut to user's profile page to admin user details (go-gitea#27299)
  Fix actionlint (go-gitea#27513)
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#27501)
  Improve feed icons and feed merge text color (go-gitea#27498)
  Downgrade `go-co-op/gocron` to v1.31.1 (go-gitea#27511)
  Enable markdownlint `no-duplicate-header` (go-gitea#27500)
  bump go-deps (go-gitea#27489)
  Apply to became a maintainer (go-gitea#27491)
  change runner for binary
  [skip ci] Updated translations via Crowdin
  Remove .exe suffix when cross-compiling on Windows (go-gitea#27448)
  move re-useable workflow
  add checkout to disk-clean
  use hosted runners for nightly actions (go-gitea#27485)
  Avoid run change title process when the title is same (go-gitea#27467)
  Fix panic in storageHandler (go-gitea#27446)
  Rename the default themes to gitea-light, gitea-dark, gitea-auto (go-gitea#27419)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 6, 2024
@6543 6543 added the backport/done All backports for this PR have been created label Feb 22, 2024
@6543
Copy link
Member

6543 commented Feb 22, 2024

gitea/go.mod

Line 44 in 511298e

github.com/go-co-op/gocron v1.31.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants