Always delete existing scheduled action tasks

[KN4CK3R]

Fixes #27650

[delvh]

Something I'm not sure about:
Are our cron schedules relative or absolute?
So, does * /5 * * * mean run at multiples of 5 minutes `starting at 0` , or does it mean run at multiples of 5 minutes `starting now`?
If it is the latter, we will now get somewhat buggy behavior as the existing schedule is cleared.

[KN4CK3R]

The behaviour should not be different than before. If the commit changed something unrelated to the scheduled action, all existing tasks are removed and re-added.

This PR just forces the deletion even if the config does not contain a scheduled action anymore.

[lunny]

I don't think this PR fixed #27650. The problem is when pushing an error parsed yaml, all old schedule tasks haven't been stop. So we need to check cron jobs when parsing workflow yaml file failed.

[delvh]

I don't think this PR fixed #27650. The problem is when pushing an error parsed yaml, all old schedule tasks haven't been stop

Well, that is one a completely different problem and two not the critical problem as that can be easily fixed by users.
The biggest problem is fixed by this PR already-

[lunny]

I think you are right these are 2 bugs . I think this PR just fixed one of two so it should be partially fix in the description.

This PR just resolved if the workflows are deleted but not from valid to invalid.

According togo u #27650, the second screenshot displayed the yaml file parse failed I think which is the real reason that the old cron jobs haven't been deleted.

[KN4CK3R]

Isn't that case covered too? If the file is invalid DetectWorkflows returns nothing but in the end my changed method is called which removes the scheduled actions.

[lunny]

in line 149, if parse failed, it will return error but will not invoke handleSchedules which is located line 191.
Looks like you are right, it just display a warn but not return error.

	workflows, schedules, err := actions_module.DetectWorkflows(gitRepo, commit, input.Event, input.Payload)
	if err != nil {
		return fmt.Errorf("DetectWorkflows: %w", err)
	}