Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gap between diff boxes (#27776) #27781

Merged
merged 1 commit into from Oct 25, 2023
Merged

Add gap between diff boxes (#27776) #27781

merged 1 commit into from Oct 25, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #27776 by @silverwind

Before (almost no gap between files):
Screenshot 2023-10-24 at 19 43 32

After (with 8px gap):
Screenshot 2023-10-24 at 19 43 22

@silverwind @GiteaBot
Add gap between diff boxes (go-gitea#27776)
261f70a 
Before (almost no gap between files):
<img width="1240" alt="Screenshot 2023-10-24 at 19 43 32"
src="https://github.com/go-gitea/gitea/assets/115237/30cdbdbc-d102-479c-89ce-3f68837ae0cd">

After (with 8px gap):
<img width="1241" alt="Screenshot 2023-10-24 at 19 43 22"
src="https://github.com/go-gitea/gitea/assets/115237/72b26a30-8730-4a36-8de9-be143b684b98">
@GiteaBot GiteaBot added modifies/frontend type/enhancement An improvement of existing functionality labels Oct 24, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 24, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Oct 24, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2023
@silverwind silverwind enabled auto-merge (squash) October 24, 2023 22:47
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2023
@silverwind silverwind merged commit 9dd8f34 into go-gitea:release/v1.21 Oct 25, 2023
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh Awaiting requested review from delvh

@denyskon denyskon Awaiting requested review from denyskon

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GiteaBot @lunny @silverwind