Use maintained gziphandler #27894
Closed
Use maintained gziphandler #27894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://github.com/NYTimes/gziphandler doesn't seems to be maintained anymore and Forgejo already includes https://github.com/klauspost/compress which provides a maintained and faster gzip handler fork. - Enables Jitter to prevent BREACH attacks, as this *seems* to be possible in the context of Forgejo. (cherry picked from commit 45a16f8c3c6f7d5e4aab8fdde6a621cf36e4801c)
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
reviewed
Nov 3, 2023
| "github.com/prometheus/client_golang/prometheus" | ||
| ) | ||
|
|
||
| const ( | ||
| // GzipMinSize represents min size to compress for the body size of response | ||
| GzipMinSize = 1400 |
There was a problem hiding this comment.
How about GzipMinSize = gzhttp.DefaultMinSize?
|
The library's License looks like some complicated. |
It looks like the |
|
The removed license should be equal to the added one because the new code is a fork of the replaced code. |
delvh
approved these changes
Dec 30, 2023
GiteaBot
added
lgtm/need 1
lunny
added a commit
that referenced
this pull request
Apr 21, 2024
Replace #27894 --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 22, 2024
Replace go-gitea#27894 --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 22, 2024
Replace go-gitea#27894 --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
lunny
added a commit
that referenced
this pull request
Apr 23, 2024
lunny
added a commit
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/klauspost/compress which provides a maintained and faster gzip handler fork.
(cherry picked from commit 45a16f8c3c6f7d5e4aab8fdde6a621cf36e4801c)