Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering in app.ini and fix run mode option #2829

Merged
merged 2 commits into from
Nov 2, 2017

Conversation

Morlinest
Copy link
Member

@Morlinest Morlinest commented Nov 2, 2017

Move APP_MODE to root section in app.ini (where it should be:

AppName = Cfg.Section("").Key("APP_NAME").MustString("Gitea: Git with a cup of tea")
) and remove unused APP_MODE option.

@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #2829 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2829   +/-   ##
=======================================
  Coverage   26.84%   26.84%           
=======================================
  Files          89       89           
  Lines       17608    17608           
=======================================
  Hits         4727     4727           
  Misses      12195    12195           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f70758d...7a96d78. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2017
@sapk
Copy link
Member

sapk commented Nov 2, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 2, 2017
@lunny
Copy link
Member

lunny commented Nov 2, 2017

@Morlinest it's RUN_MODE not APP_MODE

; Either "dev", "prod" or "test", default is "dev"
RUN_MODE = dev

@lunny lunny added the type/bug label Nov 2, 2017
@lunny lunny added this to the 1.3.0 milestone Nov 2, 2017
@lunny
Copy link
Member

lunny commented Nov 2, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2017
@lafriks
Copy link
Member

lafriks commented Nov 2, 2017

Make LG-TM work

@Morlinest
Copy link
Member Author

@lunny Thx, so it was mistake in naming (I didn't check that). I changed PR to fix name instead of removing it. Also moved it in right place in app.ini file.

@sapk @lafriks FYI, changed PR a little bit.

@lafriks lafriks changed the title Fix ordering in app.ini and remove unused config option Fix ordering in app.ini and fix run mode option Nov 2, 2017
@lafriks lafriks merged commit 529f9d0 into go-gitea:master Nov 2, 2017
@Morlinest Morlinest deleted the fix/app-ini-template branch November 2, 2017 21:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants