Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing issue search index update when changing status #28325

Merged
merged 1 commit into from Dec 3, 2023

Conversation

brechtvl
Copy link
Contributor

@brechtvl brechtvl commented Dec 2, 2023

Changing an issue status, assignee, labels or milestone without also adding a comment would not update the index, resulting in wrong search results.

Changing an issue status, assignee, labels or milestone without also adding
a comment would not update the index, resulting in wrong search results.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2023
@brechtvl
Copy link
Contributor Author

brechtvl commented Dec 2, 2023

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2023
@techknowlogick techknowlogick added backport/v1.21 This PR should be backported to Gitea 1.21 type/bug labels Dec 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2023
@KN4CK3R KN4CK3R merged commit bffbf08 into go-gitea:main Dec 3, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 3, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 3, 2023
…28325)

Changing an issue status, assignee, labels or milestone without also
adding a comment would not update the index, resulting in wrong search
results.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 3, 2023
lafriks pushed a commit that referenced this pull request Dec 3, 2023
…28330)

Backport #28325 by @brechtvl

Changing an issue status, assignee, labels or milestone without also
adding a comment would not update the index, resulting in wrong search
results.

Co-authored-by: Brecht Van Lommel <brecht@blender.org>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 4, 2023
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix missing issue search index update when changing status (go-gitea#28325)
  Keep profile tab when clicking on Language (go-gitea#28320)
  Fix wrong link in `protect_branch_name_pattern_desc` (go-gitea#28313)
  Fix links in docs (go-gitea#28302)
pangliang pushed a commit to pangliang/gitea that referenced this pull request Dec 5, 2023
…28325)

Changing an issue status, assignee, labels or milestone without also
adding a comment would not update the index, resulting in wrong search
results.
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
…28325)

Changing an issue status, assignee, labels or milestone without also
adding a comment would not update the index, resulting in wrong search
results.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
…28325)

Changing an issue status, assignee, labels or milestone without also
adding a comment would not update the index, resulting in wrong search
results.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants