Refactor template empty checks (#28351) #28354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
modifies/templates
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
jolheiser
approved these changes
Dec 5, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Dec 5, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
@GiteaBot please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #28351 by @KN4CK3R
Fix #28347
As there is no info how to reproduce it, I can't test it.
Fix may be
section_split.tmpl @ 126/130.Other changes are "empty check" refactorings.