Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong link in user and organization profile when using relative url #28617

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

katsusan
Copy link
Contributor

@katsusan katsusan commented Dec 26, 2023

fix #28436.
the doc https://docs.gitea.com/usage/profile-readme maybe also need to be updated to tell that
the main branch is necessary,which means the following three conditions should be satisfied:

  • repo: .profile
  • branch: [default branch]
  • markdown: README.md

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 26, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 26, 2023
routers/web/user/profile.go Outdated Show resolved Hide resolved
@katsusan katsusan changed the title fix wrong link in user profile when using relative url fix wrong link in user and organization profile when using relative url Dec 27, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2023
@lunny lunny added type/bug reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 27, 2023
@lunny lunny enabled auto-merge (squash) December 27, 2023 07:30
@lunny lunny merged commit 42149ff into go-gitea:main Dec 27, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 27, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 27, 2023
@katsusan katsusan deleted the fix-profile-url branch December 27, 2023 10:34
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 29, 2023
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  switch destination directory for apt signing keys (go-gitea#28639)
  Extend description for ARTIFACT_RETENTION_DAYS (go-gitea#28626)
  Refactor timeutil package (go-gitea#28623)
  Refactor some legacy code and remove unused code (go-gitea#28622)
  Remove unnecessary syncbranchToDB with tests (go-gitea#28624)
  Do not set `Accept` header twice (go-gitea#28598)
  [skip ci] Updated translations via Crowdin
  fix wrong link in user and organization profile when using relative url (go-gitea#28617)
  Add get actions runner registration token for API routes, repo, org, user and global level (go-gitea#27144)
  Fix session key conflict with database keyword (go-gitea#28613)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 10, 2024
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
…rl (go-gitea#28617)

fix go-gitea#28436.
the doc https://docs.gitea.com/usage/profile-readme maybe also need to
be updated to tell that
the main branch is necessary,which means the following three conditions
should be satisfied:
- repo: **.profile**
- branch: **[default branch]**
- markdown: **README.md**
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
…rl (go-gitea#28617)

fix go-gitea#28436.
the doc https://docs.gitea.com/usage/profile-readme maybe also need to
be updated to tell that
the main branch is necessary,which means the following three conditions
should be satisfied:
- repo: **.profile**
- branch: **[default branch]**
- markdown: **README.md**
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative URLs not working in profile page README
4 participants