Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix migration test #28659

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Fix migration test #28659

merged 2 commits into from
Dec 30, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 30, 2023

Extract from #28633

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 30, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 30, 2023
@delvh
Copy link
Member

delvh commented Dec 30, 2023

I still don't understand, how does this change anything?

@lunny lunny mentioned this pull request Dec 30, 2023
Merged
@lunny
Copy link
Member Author

lunny commented Dec 30, 2023 •
edited

PrepareTestEnv will load fixture under ./fixtures/Test_AddCombinedIndexToIssueUser and insert into the database. But in the original testing, some table issue_user's columns missed.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 30, 2023
@wxiaoguang
Copy link
Contributor

The testing system is somewhat broken, but I haven't got time to look into.

For example: does the migration tests really work well?

@wxiaoguang wxiaoguang merged commit cb10f27 into go-gitea:main Dec 30, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 30, 2023
@lunny lunny deleted the lunny/fix_migrate branch December 30, 2023 13:55
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 2, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
772be15 
* giteaofficial/main:
  Add global setting how timestamps should be rendered (go-gitea#28657)
  [skip ci] Updated translations via Crowdin
  Upgrade xorm to new version which supported update join for all supported databases (go-gitea#28590)
  Fix: system webhooks API bug (go-gitea#28531)
  Fix alpine package files are not rebuilt (go-gitea#28638)
  Fix migration test (go-gitea#28659)
  Avoid cycle-redirecting user/login page (go-gitea#28636)
  Fix long package version names overflowing (go-gitea#28619)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@lunny @fuxiaohei
Fix migration test (go-gitea#28659)
34b1398
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@lunny @silverwind
Fix migration test (go-gitea#28659)
e6819fe
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/migrations size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/testing
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @delvh @wxiaoguang @GiteaBot