Don't do a full page load when clicking Watch or Star
#29001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The watch/unwatch button and star/unstar get their own template - The backend returns HTML instead of redirect Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
delvh
approved these changes
Jan 31, 2024
GiteaBot
added
lgtm/need 1
jolheiser
reviewed
Jan 31, 2024
routers/web/repo/repo.go
Outdated
Comment on lines
342
to
364
| switch ctx.Params(":action") { | ||
| case "watch", "unwatch": | ||
| ctx.Data["IsWatchingRepo"] = repo_model.IsWatching(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID) | ||
| case "star", "unstar": | ||
| ctx.Data["IsStaringRepo"] = repo_model.IsStaring(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID) | ||
| } | ||
|
|
||
| switch ctx.Params(":action") { | ||
| case "watch", "unwatch", "star", "unstar": | ||
| ctx.Data["Repository"], err = repo_model.GetRepositoryByName(ctx, ctx.Repo.Repository.OwnerID, ctx.Repo.Repository.Name) | ||
| if err != nil { | ||
| ctx.ServerError(fmt.Sprintf("Action (%s)", ctx.Params(":action")), err) | ||
| return | ||
| } | ||
| } | ||
|
|
||
| switch ctx.Params(":action") { | ||
| case "watch", "unwatch": | ||
| ctx.HTML(http.StatusOK, tplWatchUnwatch) | ||
| return | ||
| case "star", "unstar": | ||
| ctx.HTML(http.StatusOK, tplStarUnstar) | ||
| } |
There was a problem hiding this comment.
I doubt it makes a significant difference, but can we extract ctx.Params(":action") to a variable and use that instead of four lookups?
There was a problem hiding this comment.
Can you suggest code? I am not sure how exactly you want it
jolheiser
reviewed
Jan 31, 2024
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
This reverts commit 2c5aaa5. It broke the initial page load
|
@jolheiser I had to revert because the RepoAssignment middleware writes to |
lunny
reviewed
Feb 4, 2024
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
lunny
approved these changes
Feb 5, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
wxiaoguang
reviewed
Feb 5, 2024
wxiaoguang
reviewed
Feb 5, 2024
wxiaoguang
removed
the
reviewed/wait-merge
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
wxiaoguang
approved these changes
Feb 5, 2024
wxiaoguang
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Merged
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 7, 2024
* giteaofficial/main: Hide code links on release page if user cannot read code (go-gitea#29064) [skip ci] Updated translations via Crowdin Don't do a full page load when clicking `Watch` or `Star` (go-gitea#29001) Remove useless template file (go-gitea#29053) Fix typos in the documentation (go-gitea#29048) Move some repository transfer functions to service layer (go-gitea#28855) Propagate install_if and provider_priority to APKINDEX (go-gitea#28899)
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
…9001) - The watch/unwatch button and star/unstar get their own template - The backend returns HTML instead of redirect --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After