Improve user experience for outdated comments #29050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
lunny
approved these changes
Feb 4, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
force-pushed
the
improve-review-outdated
branch
from
a8b7826
to
0bf8079
Compare
wxiaoguang
force-pushed
the
improve-review-outdated
branch
from
0bf8079
to
fb5008d
Compare
wxiaoguang
added
type/enhancement
silverwind
approved these changes
Feb 7, 2024
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 8, 2024
Try to improve go-gitea#28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`)
wxiaoguang
added a commit
that referenced
this pull request
Feb 8, 2024
Backport #29050 by wxiaoguang Try to improve #28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
jpraet
added a commit
to jpraet/gitea
that referenced
this pull request
Feb 17, 2024
…go-gitea#29203) Backport go-gitea#29203 Relates to go-gitea#28654, go-gitea#29039 and go-gitea#29050. The "show outdated comments" flag should only apply to the file diff view. On the PR timeline, outdated comments are always shown. So they should also be loaded when (un)resolving a conversation on the timeline page.
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Try to improve go-gitea#28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`)
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
…go-gitea#29203) Relates to go-gitea#28654, go-gitea#29039 and go-gitea#29050. The "show outdated comments" flag should only apply to the file diff view. On the PR timeline, outdated comments are always shown. So they should also be loaded when (un)resolving a conversation on the timeline page.
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to improve #28949
ctx.Data["ShowOutdatedComments"] = trueby default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable.ShowOutdatedComments = false)