Restore build as the default make rule #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2935 +/- ##
==========================================
+ Coverage 27.24% 27.26% +0.01%
==========================================
Files 89 89
Lines 17640 17640
==========================================
+ Hits 4806 4809 +3
+ Misses 12146 12144 -2
+ Partials 688 687 -1
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
appleboy
approved these changes
Nov 19, 2017
|
@ethantkoenig Good. make sense. LGTM |
tboerger
added
lgtm/need 1
appleboy
added
the
topic/build
|
LGTM |
tboerger
added
lgtm/done
|
@ethantkoenig good catch. Sorry, I didn't expect that to happen. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a (presumably?) unintended side-effect of #1985. Right now,
make dockeris the default rule.cc @sapk