Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply tailwindcss rules with !important #29437

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Apply tailwindcss rules with !important #29437

merged 2 commits into from
Feb 27, 2024

Conversation

silverwind
Copy link
Member

As per discussion in #29423, I think this is the right way that does not burden developers having to think about CSS precedence which should be irrelevant with a atomic CSS framework.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 27, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
@silverwind silverwind mentioned this pull request Feb 27, 2024
Merged
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 27, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2024
wxiaoguang
wxiaoguang reviewed Feb 27, 2024
View reviewed changes
tailwind.config.js Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2024
@lunny @wxiaoguang
Update tailwind.config.js
cc8010d 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 27, 2024
@lunny lunny enabled auto-merge (squash) February 27, 2024 03:00
@lunny lunny merged commit e55926e into go-gitea:main Feb 27, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 27, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 27, 2024
@wxiaoguang
Copy link
Contributor

Isn't it changed and merged too fast?

I think we should wait for silverwind to confirm whether they likes or would like to improve the comment, just wait for several hours.

@silverwind silverwind deleted the tw-important branch February 27, 2024 08:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @wxiaoguang @techknowlogick @lunny @GiteaBot