Make runs-on support variable expression #29468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
the
modifies/api
KN4CK3R
previously requested changes
Feb 28, 2024
GiteaBot
added
lgtm/blocked
lunny
reviewed
Feb 29, 2024
lunny
reviewed
Feb 29, 2024
sillyguodong
changed the title
lunny
reviewed
Mar 1, 2024
lunny
reviewed
Mar 1, 2024
TKaxv-7S
pushed a commit
to TKaxv-7S/gitea-act
that referenced
this pull request
Mar 1, 2024
Partial implementation of https://gitea.com/gitea/act_runner/issues/445, the Gitea side also needs a PR for the entire functionality. Gitea side: go-gitea/gitea#29468 Co-authored-by: Jason Song <i@wolfogre.com> Reviewed-on: https://gitea.com/gitea/act/pulls/91 Reviewed-by: Jason Song <i@wolfogre.com> Co-authored-by: sillyguodong <gedong_1994@163.com> Co-committed-by: sillyguodong <gedong_1994@163.com>
lunny
reviewed
Mar 1, 2024
lunny
approved these changes
Mar 4, 2024
|
@KN4CK3R I have addressed the requested changes in the PR. Could you please re-review it? Thank you! |
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wolfogre
approved these changes
Mar 8, 2024
|
I was unable to create a backport for 1.21. @sillyguodong, please send one manually. 🍵 |
GiteaBot
added
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 8, 2024
* giteaofficial/main: Add cache for branch divergence on branch list page (go-gitea#29577) Fix user-defined markup links targets (go-gitea#29305) Don't show AbortErrors on logout (go-gitea#29639) Style fomantic grey labels (go-gitea#29458) Don't use `<br />` in alert block (go-gitea#29650) Fix incorrect rendering csv file when file size is larger than UI.CSV.MaxFileSize (go-gitea#29653) Set user's 24h preference from their current OS locale (go-gitea#29651) Move get/set default branch from git package to gitrepo package to hide repopath (go-gitea#29126) Make runs-on support variable expression (go-gitea#29468)
lunny
pushed a commit
that referenced
this pull request
Mar 14, 2024
backport #29468 Close issue: https://gitea.com/gitea/act_runner/issues/445 Follow: https://gitea.com/gitea/act/pulls/91 Move `getSecretsOfTask` and `getVariablesOfTask` under models because of circular dependency issues.
TKaxv-7S
pushed a commit
to TKaxv-7S/gitea-act
that referenced
this pull request
Mar 25, 2024
Partial implementation of https://gitea.com/gitea/act_runner/issues/445, the Gitea side also needs a PR for the entire functionality. Gitea side: go-gitea/gitea#29468 Co-authored-by: Jason Song <i@wolfogre.com> Reviewed-on: https://gitea.com/gitea/act/pulls/91 Reviewed-by: Jason Song <i@wolfogre.com> Co-authored-by: sillyguodong <gedong_1994@163.com> Co-committed-by: sillyguodong <gedong_1994@163.com>
Merged
wolfogre
added a commit
that referenced
this pull request
Apr 11, 2024
Fix #30361, regression of #29782 which is a backport, not the original #29468. #29468 did a small refactor which introduced a new function `GetVariablesOfRun`. However, it's designed for v1.22 which supports global variables. After backporting it to v1.21, it will still try to get global variables, which causes it to retrieve all variables.
silverwind
pushed a commit
that referenced
this pull request
Apr 23, 2024
Follow #29468 1. Interpolate runs-on with variables when scheduling tasks. 2. The `GetVariablesOfRun` function will check if the `Repo` of the run is nil. --------- Co-authored-by: Giteabot <teabot@gitea.io>
sillyguodong
added a commit
to sillyguodong/gitea
that referenced
this pull request
Apr 24, 2024
) Follow go-gitea#29468 1. Interpolate runs-on with variables when scheduling tasks. 2. The `GetVariablesOfRun` function will check if the `Repo` of the run is nil. --------- Co-authored-by: Giteabot <teabot@gitea.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Close issue: https://gitea.com/gitea/act_runner/issues/445
Follow: https://gitea.com/gitea/act/pulls/91
Move
getSecretsOfTaskandgetVariablesOfTaskundermodelsbecause of circular dependency issues.