Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate some more "OptionalBool" to "Option[bool]" #29479

Merged
merged 10 commits into from Feb 29, 2024
Merged

migrate some more "OptionalBool" to "Option[bool]" #29479

merged 10 commits into from Feb 29, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 28, 2024

just some refactoring bits towards replacing util.OptionalBool with optional.Option[bool]

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2024
@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Feb 28, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2024
KN4CK3R
KN4CK3R reviewed Feb 28, 2024
View reviewed changes
models/repo/repo_list.go Outdated Show resolved Hide resolved
models/repo/repo_list_test.go Outdated Show resolved Hide resolved
modules/optional/option_test.go Outdated Show resolved Hide resolved
6543
6543 commented Feb 29, 2024
View reviewed changes
models/repo/repo_list_test.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from KN4CK3R February 29, 2024 00:34
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 29, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 29, 2024
@lunny lunny enabled auto-merge (squash) February 29, 2024 14:42
@lunny lunny merged commit f665618 into go-gitea:main Feb 29, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 29, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 29, 2024
@6543 6543 deleted the rm_OptionalBool_take2 branch February 29, 2024 19:34
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 1, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fe2d7b0 
* giteaofficial/main:
  Don’t comment when locking (go-gitea#29508)
  [skip ci] Updated translations via Crowdin
  migrate some more "OptionalBool" to "Option[bool]" (go-gitea#29479)
  Update FAQ about git hook problems (go-gitea#29495)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@6543 @lunny @KN4CK3R @GiteaBot