Do some performance optimize for issues list and view issue/pull #29515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/api
lunny
commented
Mar 1, 2024
| @@ -323,10 +323,6 @@ func ListRepoIssueComments(ctx *context.APIContext) { | |||
| ctx.Error(http.StatusInternalServerError, "LoadIssues", err) | |||
| return | |||
| } | |||
| if err := comments.LoadPosters(ctx); err != nil { | |||
There was a problem hiding this comment.
Remove duplicated load posters with line 316.
wolfogre
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Mar 12, 2024
GiteaBot
added
lgtm/done
Co-authored-by: Zettat123 <zettat123@gmail.com>
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 12, 2024
* upstream/main: Add more stats tables (go-gitea#29730) Use Get but not Post to get actions artifacts (go-gitea#29734) Do some performance optimize for issues list and view issue/pull (go-gitea#29515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR do some performance optimzations.
indexfor the columncomment_idofAttachmenttable to accelerate query from the database.