Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix over-escaped characters #2956

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Fix over-escaped characters #2956

merged 2 commits into from
Nov 22, 2017

Conversation

ethantkoenig
Copy link
Member

Fixes #2872. We do not need to call Sanitize in templates, because the html/template library already escapes strings for us.

@codecov-io
Copy link

codecov-io commented Nov 22, 2017 •
edited

Codecov Report

Merging #2956 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2956   +/-   ##
======================================
  Coverage    26.8%   26.8%           
======================================
  Files          90      90           
  Lines       17807   17807           
======================================
  Hits         4774    4774           
  Misses      12353   12353           
  Partials      680     680

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb7715...168c2b0. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 22, 2017
@lafriks
Copy link
Member

lafriks commented Nov 22, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 22, 2017
@lafriks lafriks modified the milestones: 1.4.0, 1.3.0 Nov 22, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2017
@lunny lunny merged commit 2cb6c51 into go-gitea:master Nov 22, 2017
@ethantkoenig ethantkoenig deleted the fix/html_escape branch November 25, 2017 05:09
@lafriks
Copy link
Member

lafriks commented Nov 27, 2017

@ethantkoenig can you backport this?

@lafriks lafriks modified the milestones: 1.3.0, 1.4.0 Nov 27, 2017
@ethantkoenig ethantkoenig mentioned this pull request Nov 27, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Nov 27, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Over-Escaped Wiki Page Title
6 participants
@ethantkoenig @codecov-io @lafriks @appleboy @lunny @tboerger