Use more specific selector for name links
#29679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
added
the
skip-changelog
denyskon
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/done
|
I agree with you @silverwind. Tested your code locally and it worked as intended. Besides, this way, since we restrict the search to only the div that has class |
silverwind
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 8, 2024
Followup go-gitea#29305. As per discussion in go-gitea#29666 (comment), make this selector only search in the current `.markup` document, as there can be multiples displayed at the same time. @DanielMatiasCarvalho maybe you can review.
GiteaBot
added
backport/done
silverwind
added a commit
that referenced
this pull request
Mar 9, 2024
Backport #29679 by @silverwind Followup #29305. As per discussion in #29666 (comment), make this selector only search in the current `.markup` document, as there can be multiples displayed at the same time. @DanielMatiasCarvalho maybe you can review. Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 9, 2024
* upstream/main: Patch in exact search for meilisearch (go-gitea#29671) Use more specific selector for `name` links (go-gitea#29679) Replace more gt- with tw- (go-gitea#29678) # Conflicts: # templates/user/dashboard/issues.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #29305. As per discussion in #29666 (comment), make this selector only search in the current
.markupdocument, as there can be multiples displayed at the same time.@DanielMatiasCarvalho maybe you can review.