Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable content trust when building image #2972

Merged
merged 1 commit into from
Dec 3, 2017
Merged

Enable content trust when building image #2972

merged 1 commit into from
Dec 3, 2017

Conversation

0rzech
Copy link
Contributor

@0rzech 0rzech commented Nov 25, 2017

Enable base image verification at docker build phase.

@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Nov 25, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 25, 2017
@codecov-io
Copy link

codecov-io commented Nov 25, 2017 •
edited
Loading

Codecov Report

Merging #2972 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2972      +/-   ##
==========================================
+ Coverage   33.42%   33.47%   +0.05%     
==========================================
  Files         270      270              
  Lines       39564    39534      -30     
==========================================
+ Hits        13224    13235      +11     
+ Misses      24452    24408      -44     
- Partials     1888     1891       +3
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo.go 38.08% <0%> (-0.08%) ⬇️
models/repo_mirror.go 3.77% <0%> (+0.56%) ⬆️
modules/indexer/repo.go 63.47% <0%> (+2.6%) ⬆️
models/repo_indexer.go 51.98% <0%> (+6.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d99840...1e6fc39. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2017
@sapk
Copy link
Member

sapk commented Nov 26, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2017
@lunny
Copy link
Member

lunny commented Dec 3, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2017
@lunny
Copy link
Member

lunny commented Dec 3, 2017

need rebase

@0rzech
Copy link
Contributor Author

0rzech commented Dec 3, 2017 •
edited
Loading

@lunny Done.

@lunny lunny merged commit 7bab3d2 into go-gitea:master Dec 3, 2017
@0rzech 0rzech deleted the docker-content-trust-build branch December 3, 2017 18:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@0rzech @codecov-io @sapk @lunny @tboerger @lafriks