Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible NPE in ToPullReviewList (#29759) #29775

Merged
merged 1 commit into from Mar 13, 2024
Merged

Fix possible NPE in ToPullReviewList (#29759) #29775

merged 1 commit into from Mar 13, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #29759 by @lunny

@lunny @wxiaoguang @GiteaBot
Fix possible NPE in ToPullReviewList (go-gitea#29759)
de741de 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code type/bug labels Mar 13, 2024
@GiteaBot GiteaBot requested a review from lng2020 March 13, 2024 19:46
@GiteaBot GiteaBot added this to the 1.21.9 milestone Mar 13, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 13, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 13, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 13, 2024
@silverwind silverwind merged commit 5e3581f into go-gitea:release/v1.21 Mar 13, 2024
27 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@lng2020 lng2020 lng2020 approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

@lunny lunny

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.21.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GiteaBot @silverwind @lng2020 @lunny