Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env (#29788) #29791

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env (#29788) #29791

merged 2 commits into from
Mar 14, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #29788 by @wolfogre

I was trying to run unit tests for Gitea on act runner, by using make test.

It failed with log:

2024/03/14 03:09:26 ...s/setting/setting.go:180:loadRunModeFrom() [F] Gitea is not supposed to be run as root. Sorry. If you need to use privileged TCP ports please instead use setcap and the `cap_net_bind_service` permission

So it will be convenient to skip by setting environment, since it's OK to use root user in job containers.

It's not a bug, but I want to backport it to v1.21 since it doesn't break anything.

@wolfogre @GiteaBot @wxiaoguang
Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env (go-gitea#29788)
ef57ba5 
It is convenient to skip by setting environment, since it's OK
to use root user in job containers.

It's not a bug, but I want to backport it to v1.21 since it doesn't
break anything.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 14, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2024
@GiteaBot GiteaBot added this to the 1.21.9 milestone Mar 14, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2024
@silverwind
Copy link
Member

silverwind commented Mar 14, 2024 •
edited

Lint is failing, backport likely needs to be done manually.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2024
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2024
@wolfogre wolfogre enabled auto-merge (squash) March 14, 2024 09:58
@wolfogre wolfogre merged commit e0a9a92 into go-gitea:release/v1.21 Mar 14, 2024
27 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

@wolfogre wolfogre

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.21.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GiteaBot @silverwind @lunny @wolfogre