Use Temporal.PlainDate for absolute dates
#29804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
silverwind
added
type/refactoring
yardenshoham
approved these changes
Mar 15, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Mar 15, 2024
GiteaBot
added
lgtm/done
|
Backport? |
|
Might as well, yeah. |
pull-request-size
bot
added
size/M
|
Tests added in e1de1c7. I'm suprised they even work as expected in jsdom with non-english locale. |
silverwind
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.21. @silverwind, please send one manually. 🍵 |
GiteaBot
added
backport/manual
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 15, 2024
Use the upcoming [Temporal.PlainDate](https://tc39.es/proposal-temporal/docs/plaindate.html) via polyfill. If there is any remaining bugs in `<absolute-date>` this will iron them out. I opted for the lightweight polyfill because both seem to achieve our goal of localizeable absolute dates. - With [`@js-temporal/polyfill`](https://www.npmjs.com/package/@js-temporal/polyfill) chunk size goes from 81.4 KiB to 274 KiB - With [`temporal-polyfill`](https://www.npmjs.com/package/temporal-polyfill) chunk size goes from 81.4 KiB to 142 KiB Also see [this table](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#comparison-with-js-temporalpolyfill) for more comparisons of these polyfills. Soon there will be [treeshakable API](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#tree-shakable-api) as well which will further reduce size.
silverwind
added
backport/done
silverwind
added a commit
that referenced
this pull request
Mar 15, 2024
Backport #29804. Use the upcoming [Temporal.PlainDate](https://tc39.es/proposal-temporal/docs/plaindate.html) via polyfill. If there is any remaining bugs in `<absolute-date>` this will iron them out. I opted for the lightweight polyfill because both seem to achieve our goal of localizeable absolute dates. - With [`@js-temporal/polyfill`](https://www.npmjs.com/package/@js-temporal/polyfill) chunk size goes from 81.4 KiB to 274 KiB - With [`temporal-polyfill`](https://www.npmjs.com/package/temporal-polyfill) chunk size goes from 81.4 KiB to 142 KiB Also see [this table](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#comparison-with-js-temporalpolyfill) for more comparisons of these polyfills. Soon there will be [treeshakable API](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#tree-shakable-api) as well which will further reduce size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the upcoming Temporal.PlainDate via polyfill. If there is any remaining bugs in
<absolute-date>this will iron them out. I opted for the lightweight polyfill because both seem to achieve our goal of localizeable absolute dates.@js-temporal/polyfillchunk size goes from 81.4 KiB to 274 KiBtemporal-polyfillchunk size goes from 81.4 KiB to 142 KiBAlso see this table for more comparisons of these polyfills. Soon there will be treeshakable API as well which will further reduce size.