-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 10 more gt- classes with tw- #29945
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Mar 20, 2024
github-actions
bot
added
modifies/go
Pull requests that update Go code
modifies/frontend
modifies/templates
This PR modifies the template files
modifies/docs
modifies/js
labels
Mar 20, 2024
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Mar 20, 2024
silverwind
added
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
modifies/go
Pull requests that update Go code
modifies/frontend
modifies/templates
This PR modifies the template files
modifies/docs
modifies/js
labels
Mar 20, 2024
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Mar 21, 2024
github-actions
bot
added
modifies/go
Pull requests that update Go code
modifies/frontend
modifies/templates
This PR modifies the template files
modifies/docs
modifies/js
labels
Mar 21, 2024
wxiaoguang
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proper prefix really helps the maintainability a lot, the names could be easily searched & replaced.
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Mar 21, 2024
Yes, in hindsight it's good we have the prefixes, it makes the migration easy and there is zero risk of false replacements. |
6543
approved these changes
Mar 22, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Mar 22, 2024
silverwind
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Mar 22, 2024
delvh
approved these changes
Mar 22, 2024
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Mar 22, 2024
This was referenced Mar 22, 2024
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 26, 2024
Fixes go-gitea/gitea#30005. Regression from go-gitea/gitea#29945. There was only once instance of `tw-content-center` before that PR, so I just ran below command and reverted that one instance. ```sh perl -p -i -e 's#tw-content-center#tw-items-center#g' web_src/js/**/* templates/**/* models/**/* tests/**/* ``` (cherry picked from commit 04f9ad056882fc3f21b247b16f84437adf0f36d8) Conflicts: templates/repo/diff/conversation.tmpl templates/repo/header.tmpl templates/repo/issue/filter_list.tmpl templates/repo/issue/view_content/conversation.tmpl templates/repo/wiki/view.tmpl web_src/js/components/DashboardRepoList.vue re-ran the command after discarding the Gitea changes to ensure all Forgejo files are also covered
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/docs
modifies/go
Pull requests that update Go code
modifies/js
modifies/templates
This PR modifies the template files
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely the biggest change of the tailwind refactors. Only thing of note is that
tw-flex-1
resolves toflex: 1 1 0%
while ourgt-f1
wasflex: 1 1 0
, I don't think it will make any difference. Commands I've ran:edit: corrected
gt-ac
replacement for future reference