Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements for pull request list page (#29900) #29972

Merged
merged 2 commits into from Mar 22, 2024
Merged

Performance improvements for pull request list page (#29900) #29972

merged 2 commits into from Mar 22, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 21, 2024 •
edited

This PR will avoid load pullrequest.Issue twice in pull request list page. It will reduce x times database queries for those WIP pull requests.

Partially fix #29585
Backport #29900

@lunny @GiteaBot
Performance improvements for pull request list page (go-gitea#29900)
10a9161 
This PR will avoid load pullrequest.Issue twice in pull request list
page. It will reduce x times database queries for those WIP pull
requests.

Partially fix go-gitea#29585

---------

Co-authored-by: Giteabot <teabot@gitea.io>
@lunny lunny added the performance/speed performance issues with slow downs label Mar 21, 2024
@lunny lunny added this to the 1.21.9 milestone Mar 21, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 21, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 21, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Mar 21, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 21, 2024
@lunny lunny mentioned this pull request Mar 21, 2024
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2024
@wolfogre wolfogre merged commit 6ef986d into go-gitea:release/v1.21 Mar 22, 2024
27 checks passed
@lunny lunny deleted the lunny/pulls_performance2 branch March 22, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files performance/speed performance issues with slow downs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.21.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @silverwind @wolfogre @GiteaBot